Skip to content

Fresh {} is subtype of object #49503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2022
Merged

Fresh {} is subtype of object #49503

merged 2 commits into from
Jun 13, 2022

Conversation

ahejlsberg
Copy link
Member

@ahejlsberg ahejlsberg commented Jun 12, 2022 •
edited
Loading

Fixes #49480.
Fixes #49520.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 12, 2022
@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 12, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 26df65a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 12, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 26df65a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 12, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 26df65a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 12, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 26df65a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49503

Metric main 49503 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 333,858k (± 0.01%) 333,848k (± 0.01%) -10k (- 0.00%) 333,805k 333,936k
Parse Time 2.07s (± 0.69%) 2.08s (± 0.57%) +0.01s (+ 0.34%) 2.05s 2.10s
Bind Time 0.89s (± 0.62%) 0.89s (± 0.33%) -0.00s (- 0.45%) 0.88s 0.89s
Check Time 5.74s (± 0.61%) 5.72s (± 0.41%) -0.03s (- 0.45%) 5.66s 5.77s
Emit Time 6.41s (± 0.75%) 6.41s (± 0.87%) -0.00s (- 0.03%) 6.32s 6.58s
Total Time 15.12s (± 0.45%) 15.10s (± 0.42%) -0.02s (- 0.14%) 14.95s 15.24s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,578k (± 0.02%) 192,591k (± 0.03%) +13k (+ 0.01%) 192,513k 192,699k
Parse Time 0.84s (± 0.90%) 0.84s (± 0.43%) +0.00s (+ 0.00%) 0.84s 0.85s
Bind Time 0.58s (± 0.96%) 0.58s (± 0.38%) +0.00s (+ 0.52%) 0.58s 0.59s
Check Time 7.67s (± 0.54%) 7.64s (± 0.60%) -0.02s (- 0.29%) 7.58s 7.77s
Emit Time 2.52s (± 0.74%) 2.51s (± 1.62%) -0.01s (- 0.28%) 2.46s 2.63s
Total Time 11.61s (± 0.49%) 11.58s (± 0.59%) -0.03s (- 0.24%) 11.48s 11.80s
Monaco - node (v14.15.1, x64)
Memory used 325,634k (± 0.01%) 325,621k (± 0.00%) -14k (- 0.00%) 325,586k 325,660k
Parse Time 1.59s (± 0.65%) 1.57s (± 0.55%) -0.02s (- 1.01%) 1.56s 1.59s
Bind Time 0.79s (± 0.84%) 0.79s (± 0.63%) -0.01s (- 0.88%) 0.78s 0.80s
Check Time 5.67s (± 0.37%) 5.66s (± 0.35%) -0.00s (- 0.09%) 5.63s 5.73s
Emit Time 3.34s (± 0.71%) 3.38s (± 0.69%) +0.04s (+ 1.17%) 3.34s 3.43s
Total Time 11.39s (± 0.37%) 11.41s (± 0.41%) +0.01s (+ 0.10%) 11.33s 11.55s
TFS - node (v14.15.1, x64)
Memory used 288,730k (± 0.01%) 288,716k (± 0.01%) -14k (- 0.00%) 288,660k 288,760k
Parse Time 1.33s (± 1.01%) 1.32s (± 0.70%) -0.01s (- 0.53%) 1.30s 1.35s
Bind Time 0.76s (± 0.77%) 0.76s (± 0.96%) +0.00s (+ 0.13%) 0.74s 0.77s
Check Time 5.34s (± 0.57%) 5.31s (± 0.38%) -0.03s (- 0.54%) 5.28s 5.36s
Emit Time 3.57s (± 2.11%) 3.52s (± 1.97%) -0.05s (- 1.51%) 3.44s 3.71s
Total Time 11.00s (± 0.79%) 10.91s (± 0.78%) -0.09s (- 0.84%) 10.82s 11.14s
material-ui - node (v14.15.1, x64)
Memory used 446,547k (± 0.00%) 446,397k (± 0.00%) -151k (- 0.03%) 446,359k 446,440k
Parse Time 1.89s (± 0.44%) 1.89s (± 0.58%) -0.00s (- 0.11%) 1.87s 1.92s
Bind Time 0.73s (± 1.29%) 0.73s (± 1.24%) -0.00s (- 0.27%) 0.71s 0.75s
Check Time 13.25s (± 0.55%) 13.11s (± 0.65%) -0.14s (- 1.03%) 12.88s 13.28s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.87s (± 0.48%) 15.73s (± 0.57%) -0.14s (- 0.88%) 15.49s 15.93s
xstate - node (v14.15.1, x64)
Memory used 537,382k (± 0.00%) 537,381k (± 0.00%) -1k (- 0.00%) 537,328k 537,426k
Parse Time 2.60s (± 0.49%) 2.61s (± 0.55%) +0.01s (+ 0.35%) 2.59s 2.66s
Bind Time 1.16s (± 1.00%) 1.15s (± 1.02%) -0.01s (- 0.69%) 1.12s 1.17s
Check Time 1.53s (± 0.73%) 1.52s (± 0.41%) -0.01s (- 0.65%) 1.51s 1.53s
Emit Time 0.07s (± 4.95%) 0.07s (± 4.13%) 🟩-0.00s (- 4.00%) 0.07s 0.08s
Total Time 5.37s (± 0.56%) 5.35s (± 0.36%) -0.01s (- 0.28%) 5.32s 5.41s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49503 10
Baseline main 10

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@ahejlsberg
Great news! no new errors were found between main..refs/pull/49503/merge

@typescript-bot
Copy link
Collaborator

Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@ahejlsberg ahejlsberg mentioned this pull request Jun 13, 2022
Closed
@DanielRosenwasser
Copy link
Member

What is going on with xstate emit time?

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 13, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 26df65a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49503

Metric main 49503 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 357,957k (± 0.02%) 357,990k (± 0.02%) +34k (+ 0.01%) 357,715k 358,112k
Parse Time 2.11s (± 0.31%) 2.09s (± 0.60%) -0.01s (- 0.62%) 2.07s 2.13s
Bind Time 0.89s (± 0.65%) 0.89s (± 0.68%) -0.01s (- 0.90%) 0.87s 0.90s
Check Time 5.95s (± 0.67%) 5.92s (± 0.47%) -0.03s (- 0.54%) 5.85s 5.99s
Emit Time 6.09s (± 0.75%) 6.11s (± 0.47%) +0.02s (+ 0.30%) 6.06s 6.19s
Total Time 15.04s (± 0.44%) 15.01s (± 0.35%) -0.03s (- 0.23%) 14.92s 15.17s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,402k (± 0.05%) 206,355k (± 0.04%) -47k (- 0.02%) 206,240k 206,537k
Parse Time 0.85s (± 0.73%) 0.85s (± 0.80%) -0.00s (- 0.35%) 0.83s 0.86s
Bind Time 0.53s (± 1.09%) 0.53s (± 1.14%) -0.00s (- 0.94%) 0.51s 0.54s
Check Time 8.16s (± 0.65%) 8.10s (± 0.49%) -0.06s (- 0.71%) 8.03s 8.20s
Emit Time 2.51s (± 0.70%) 2.50s (± 1.03%) -0.01s (- 0.40%) 2.45s 2.54s
Total Time 12.05s (± 0.49%) 11.97s (± 0.45%) -0.08s (- 0.64%) 11.84s 12.09s
Monaco - node (v10.16.3, x64)
Memory used 343,719k (± 0.01%) 343,786k (± 0.02%) +67k (+ 0.02%) 343,683k 343,906k
Parse Time 1.60s (± 0.82%) 1.60s (± 0.60%) -0.00s (- 0.19%) 1.58s 1.62s
Bind Time 0.77s (± 0.84%) 0.76s (± 0.48%) -0.00s (- 0.52%) 0.76s 0.77s
Check Time 5.95s (± 0.35%) 5.94s (± 0.46%) -0.01s (- 0.10%) 5.88s 6.00s
Emit Time 3.25s (± 0.63%) 3.23s (± 0.19%) -0.02s (- 0.52%) 3.21s 3.24s
Total Time 11.56s (± 0.39%) 11.53s (± 0.24%) -0.03s (- 0.28%) 11.48s 11.60s
TFS - node (v10.16.3, x64)
Memory used 305,143k (± 0.01%) 305,084k (± 0.02%) -59k (- 0.02%) 304,956k 305,199k
Parse Time 1.31s (± 0.76%) 1.29s (± 0.46%) -0.02s (- 1.45%) 1.28s 1.31s
Bind Time 0.73s (± 0.55%) 0.72s (± 0.68%) -0.00s (- 0.69%) 0.71s 0.73s
Check Time 5.42s (± 0.68%) 5.37s (± 0.44%) -0.05s (- 0.94%) 5.33s 5.42s
Emit Time 3.41s (± 1.23%) 3.41s (± 0.90%) -0.00s (- 0.12%) 3.34s 3.49s
Total Time 10.87s (± 0.69%) 10.79s (± 0.38%) -0.08s (- 0.72%) 10.71s 10.90s
material-ui - node (v10.16.3, x64)
Memory used 469,283k (± 0.01%) 469,114k (± 0.01%) -169k (- 0.04%) 468,965k 469,199k
Parse Time 1.85s (± 0.89%) 1.83s (± 0.51%) -0.02s (- 1.03%) 1.81s 1.85s
Bind Time 0.69s (± 1.74%) 0.70s (± 0.64%) +0.00s (+ 0.43%) 0.69s 0.71s
Check Time 14.52s (± 0.66%) 14.41s (± 0.30%) -0.11s (- 0.76%) 14.33s 14.53s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.07s (± 0.63%) 16.94s (± 0.26%) -0.12s (- 0.72%) 16.87s 17.06s
xstate - node (v10.16.3, x64)
Memory used 574,017k (± 0.01%) 577,235k (± 1.26%) +3,218k (+ 0.56%) 573,731k 606,554k
Parse Time 2.61s (± 0.32%) 2.60s (± 0.41%) -0.01s (- 0.34%) 2.59s 2.63s
Bind Time 1.03s (± 0.60%) 1.02s (± 0.85%) -0.01s (- 0.87%) 1.00s 1.04s
Check Time 1.55s (± 0.85%) 1.54s (± 0.81%) -0.01s (- 0.77%) 1.52s 1.58s
Emit Time 0.07s (± 4.13%) 0.07s (± 0.00%) -0.00s (- 2.78%) 0.07s 0.07s
Total Time 5.27s (± 0.29%) 5.23s (± 0.30%) -0.03s (- 0.63%) 5.20s 5.26s
Angular - node (v12.1.0, x64)
Memory used 335,585k (± 0.02%) 335,608k (± 0.02%) +23k (+ 0.01%) 335,460k 335,820k
Parse Time 2.10s (± 0.76%) 2.08s (± 0.45%) -0.01s (- 0.67%) 2.06s 2.11s
Bind Time 0.85s (± 0.53%) 0.84s (± 0.40%) -0.01s (- 0.59%) 0.84s 0.85s
Check Time 5.78s (± 0.45%) 5.78s (± 0.56%) +0.00s (+ 0.00%) 5.70s 5.86s
Emit Time 6.37s (± 0.76%) 6.35s (± 0.64%) -0.02s (- 0.24%) 6.25s 6.44s
Total Time 15.09s (± 0.26%) 15.05s (± 0.42%) -0.04s (- 0.27%) 14.92s 15.22s
Compiler-Unions - node (v12.1.0, x64)
Memory used 193,807k (± 0.13%) 193,965k (± 0.09%) +158k (+ 0.08%) 193,414k 194,295k
Parse Time 0.83s (± 0.84%) 0.83s (± 1.20%) -0.00s (- 0.12%) 0.81s 0.85s
Bind Time 0.55s (± 0.90%) 0.54s (± 0.74%) -0.01s (- 0.92%) 0.53s 0.55s
Check Time 7.58s (± 0.67%) 7.53s (± 0.38%) -0.06s (- 0.76%) 7.49s 7.60s
Emit Time 2.51s (± 0.94%) 2.52s (± 0.74%) +0.01s (+ 0.36%) 2.47s 2.56s
Total Time 11.47s (± 0.56%) 11.42s (± 0.27%) -0.05s (- 0.47%) 11.36s 11.47s
Monaco - node (v12.1.0, x64)
Memory used 326,847k (± 0.02%) 326,804k (± 0.02%) -42k (- 0.01%) 326,567k 326,966k
Parse Time 1.57s (± 0.68%) 1.56s (± 0.77%) -0.01s (- 0.70%) 1.54s 1.60s
Bind Time 0.76s (± 0.62%) 0.75s (± 0.74%) -0.01s (- 1.05%) 0.74s 0.76s
Check Time 5.78s (± 0.51%) 5.75s (± 0.43%) -0.03s (- 0.52%) 5.69s 5.80s
Emit Time 3.32s (± 0.70%) 3.29s (± 0.58%) -0.02s (- 0.72%) 3.26s 3.34s
Total Time 11.42s (± 0.46%) 11.35s (± 0.30%) -0.07s (- 0.60%) 11.28s 11.42s
TFS - node (v12.1.0, x64)
Memory used 289,703k (± 0.02%) 289,715k (± 0.02%) +13k (+ 0.00%) 289,575k 289,835k
Parse Time 1.30s (± 0.37%) 1.31s (± 0.79%) +0.01s (+ 0.85%) 1.29s 1.33s
Bind Time 0.75s (± 0.69%) 0.75s (± 0.60%) -0.00s (- 0.40%) 0.74s 0.76s
Check Time 5.33s (± 0.69%) 5.30s (± 0.54%) -0.03s (- 0.54%) 5.21s 5.35s
Emit Time 3.51s (± 1.07%) 3.48s (± 1.02%) -0.03s (- 0.80%) 3.40s 3.58s
Total Time 10.88s (± 0.64%) 10.84s (± 0.45%) -0.04s (- 0.40%) 10.71s 10.94s
material-ui - node (v12.1.0, x64)
Memory used 448,259k (± 0.01%) 448,175k (± 0.02%) -85k (- 0.02%) 448,054k 448,457k
Parse Time 1.86s (± 0.77%) 1.84s (± 0.67%) -0.02s (- 0.91%) 1.81s 1.86s
Bind Time 0.68s (± 1.11%) 0.68s (± 0.59%) -0.01s (- 0.88%) 0.67s 0.69s
Check Time 13.07s (± 0.78%) 12.94s (± 0.64%) -0.13s (- 1.03%) 12.82s 13.19s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.61s (± 0.73%) 15.46s (± 0.58%) -0.16s (- 1.02%) 15.31s 15.71s
xstate - node (v12.1.0, x64)
Memory used 539,581k (± 0.02%) 542,786k (± 1.31%) +3,205k (+ 0.59%) 539,424k 571,522k
Parse Time 2.57s (± 0.54%) 2.55s (± 0.39%) -0.02s (- 0.74%) 2.53s 2.58s
Bind Time 1.01s (± 0.74%) 1.00s (± 1.45%) -0.01s (- 0.69%) 0.98s 1.05s
Check Time 1.49s (± 0.65%) 1.48s (± 0.35%) -0.01s (- 0.67%) 1.47s 1.49s
Emit Time 0.07s (± 3.14%) 0.07s (± 0.00%) -0.00s (- 1.41%) 0.07s 0.07s
Total Time 5.15s (± 0.40%) 5.11s (± 0.29%) -0.04s (- 0.70%) 5.08s 5.16s
Angular - node (v14.15.1, x64)
Memory used 333,858k (± 0.01%) 333,858k (± 0.01%) +1k (+ 0.00%) 333,811k 333,927k
Parse Time 2.07s (± 0.69%) 2.07s (± 0.33%) -0.00s (- 0.24%) 2.05s 2.08s
Bind Time 0.89s (± 0.62%) 0.89s (± 0.50%) -0.00s (- 0.45%) 0.88s 0.90s
Check Time 5.74s (± 0.61%) 5.75s (± 0.58%) +0.00s (+ 0.02%) 5.69s 5.83s
Emit Time 6.41s (± 0.75%) 6.35s (± 0.42%) -0.06s (- 0.89%) 6.31s 6.43s
Total Time 15.12s (± 0.45%) 15.05s (± 0.37%) -0.06s (- 0.41%) 14.95s 15.18s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,578k (± 0.02%) 192,557k (± 0.02%) -21k (- 0.01%) 192,488k 192,644k
Parse Time 0.84s (± 0.90%) 0.85s (± 0.61%) +0.01s (+ 0.59%) 0.84s 0.86s
Bind Time 0.58s (± 0.96%) 0.58s (± 0.69%) +0.00s (+ 0.17%) 0.57s 0.59s
Check Time 7.67s (± 0.54%) 7.59s (± 0.94%) -0.08s (- 0.98%) 7.46s 7.80s
Emit Time 2.52s (± 0.74%) 2.51s (± 0.76%) -0.01s (- 0.36%) 2.45s 2.55s
Total Time 11.61s (± 0.49%) 11.52s (± 0.72%) -0.08s (- 0.70%) 11.40s 11.77s
Monaco - node (v14.15.1, x64)
Memory used 325,634k (± 0.01%) 325,607k (± 0.01%) -27k (- 0.01%) 325,579k 325,646k
Parse Time 1.59s (± 0.65%) 1.57s (± 0.64%) -0.02s (- 1.39%) 1.55s 1.60s
Bind Time 0.79s (± 0.84%) 0.78s (± 0.76%) -0.01s (- 1.13%) 0.77s 0.80s
Check Time 5.67s (± 0.37%) 5.68s (± 0.30%) +0.01s (+ 0.12%) 5.64s 5.72s
Emit Time 3.34s (± 0.71%) 3.36s (± 1.10%) +0.02s (+ 0.54%) 3.31s 3.49s
Total Time 11.39s (± 0.37%) 11.39s (± 0.35%) -0.01s (- 0.07%) 11.32s 11.53s
TFS - node (v14.15.1, x64)
Memory used 288,730k (± 0.01%) 288,714k (± 0.01%) -16k (- 0.01%) 288,662k 288,758k
Parse Time 1.33s (± 1.01%) 1.32s (± 1.15%) -0.01s (- 0.45%) 1.30s 1.36s
Bind Time 0.76s (± 0.77%) 0.75s (± 1.08%) -0.00s (- 0.53%) 0.73s 0.77s
Check Time 5.34s (± 0.57%) 5.30s (± 0.36%) -0.04s (- 0.79%) 5.25s 5.34s
Emit Time 3.57s (± 2.11%) 3.52s (± 2.06%) -0.05s (- 1.40%) 3.43s 3.69s
Total Time 11.00s (± 0.79%) 10.90s (± 0.73%) -0.10s (- 0.92%) 10.75s 11.08s
material-ui - node (v14.15.1, x64)
Memory used 446,547k (± 0.00%) 446,410k (± 0.00%) -138k (- 0.03%) 446,378k 446,439k
Parse Time 1.89s (± 0.44%) 1.88s (± 0.44%) -0.01s (- 0.48%) 1.87s 1.90s
Bind Time 0.73s (± 1.29%) 0.72s (± 1.05%) -0.01s (- 1.23%) 0.70s 0.73s
Check Time 13.25s (± 0.55%) 13.07s (± 0.41%) -0.17s (- 1.30%) 12.94s 13.18s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.87s (± 0.48%) 15.68s (± 0.36%) -0.19s (- 1.20%) 15.55s 15.80s
xstate - node (v14.15.1, x64)
Memory used 537,382k (± 0.00%) 537,391k (± 0.00%) +9k (+ 0.00%) 537,363k 537,453k
Parse Time 2.60s (± 0.49%) 2.60s (± 0.48%) -0.01s (- 0.19%) 2.58s 2.64s
Bind Time 1.16s (± 1.00%) 1.16s (± 1.30%) +0.00s (+ 0.17%) 1.13s 1.18s
Check Time 1.53s (± 0.73%) 1.53s (± 0.66%) -0.01s (- 0.33%) 1.51s 1.55s
Emit Time 0.07s (± 4.95%) 0.07s (± 3.14%) 🟩-0.00s (- 5.33%) 0.07s 0.08s
Total Time 5.37s (± 0.56%) 5.35s (± 0.46%) -0.02s (- 0.34%) 5.30s 5.41s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49503 10
Baseline main 10

Developer Information:

Download Benchmark

@ahejlsberg ahejlsberg merged commit dc6a80b into main Jun 13, 2022
@ahejlsberg ahejlsberg deleted the fix49480 branch June 13, 2022 19:21
@Andarist
Copy link
Contributor

@DanielRosenwasser is a small drop (2-4%) in XState's emit time concerning here? 🤔 Or do I read those reports all wrong?

@DanielRosenwasser
Copy link
Member

I don't know why it's showing a drop, the emit time is identical; only the variability has shrunk if I've understood it correctly (@weswigham @rbuckton)

@rbuckton
Copy link
Member

It looks like total time has improved (i.e., is lower) across the board.

@microsoft microsoft deleted a comment from typescript-bot Jun 21, 2022
@jcalz
Copy link
Contributor

jcalz commented Sep 2, 2022 •
edited
Loading

There's a Stack Overflow question that seems to be related to this PR:

interface Baz {
  foo: { a: number };
}

const createDefaultExample = <K extends keyof Baz>(x: K): Baz[K] & { x: K; } => {
  return { a: 0, x }; // okay in TS4.7, error in TS4.8
}

Playground link

Looks like the fix for #49520 might have broken this. Is it a bug and should this be filed as such? Or is it intended in some way?

EDIT: Looks like the above was fixed by #50261 but this one persists:

type Foo<K> = K extends unknown ? { a: number } : unknown
const createDefaultExample = <K,>(x: K): Foo<K> & { x: K; } => {
  return { a: 1, x: x }; // okay in TS 4.7.4, error in TS 4.8.2
}

Playground link to code

Same question, I guess... bug? Not bug? New issue?

@jcalz jcalz mentioned this pull request Sep 2, 2022
Closed
@andrewbranch andrewbranch mentioned this pull request Sep 2, 2022
Closed
@jcalz jcalz mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
8 participants
@ahejlsberg @typescript-bot @DanielRosenwasser @Andarist @rbuckton @jcalz @weswigham @RyanCavanaugh